fix(releases): use get_or_create instead of sub transaction #77453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
snigdhas
approved these changes
Sep 12, 2024
wedamija
reviewed
Sep 16, 2024
Comment on lines
60
to
61
| create_repositories(commit_list, release) | ||
| create_commit_authors(commit_list, release) |
There was a problem hiding this comment.
Are you sure we don't still want these inside of the lock, but not the transaction?
There was a problem hiding this comment.
added inside of lock, but not transaction.
JoshFerge
force-pushed
the
jferg/more-opts
branch
from
ad4ee18
to
0de6835
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
|
PR reverted: 944ae32 |
getsentry-bot
added a commit
that referenced
this pull request
Sep 17, 2024
…77453)" This reverts commit 56a2c91. Co-authored-by: JoshFerge <[email protected]>
JoshFerge
added a commit
that referenced
this pull request
Sep 17, 2024
we observed SENTRY-3F2A during the rollout of #77453. This didn't make sense until i realized our redis lock is only 10 seconds right now, and this function can take longer than that. We increase the max timeout to 10 minutes, which should be plenty for 99.99+% of `set_commits` calls.
harshithadurai
pushed a commit
that referenced
this pull request
Sep 19, 2024
we observed SENTRY-3F2A during the rollout of #77453. This didn't make sense until i realized our redis lock is only 10 seconds right now, and this function can take longer than that. We increase the max timeout to 10 minutes, which should be plenty for 99.99+% of `set_commits` calls.
harshithadurai
pushed a commit
that referenced
this pull request
Sep 19, 2024
we observed SENTRY-3F2A during the rollout of #77453. This didn't make sense until i realized our redis lock is only 10 seconds right now, and this function can take longer than that. We increase the max timeout to 10 minutes, which should be plenty for 99.99+% of `set_commits` calls.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce the amount of sub transactions by using get_or_create instead of catching integrity errors. also removes the ff flag for now. will keep the ff flag defined incase i make any more radical changes